Attention is currently required from: fixeria, laforge, pespin.

View Change

1 comment:

• File Transceiver52M/Transceiver.cpp:

  • Patch Set #1, Line 1090: return rc == -EINVAL ? 0 : rc; /* Ignore invalid values, but report other errors */

    Reading the code again more carefully, I see that we **are** bypassing `transceiver->ctrl_sock_send( […]

    `ctrl_cmd_handle()` is introduced in the following commit. In this commit, compared to the original code, the only change is replacing `return 0` with `return -EINVAL`. The call to `ctrl_sock_send()` was already bypassed in that case before — `ctrl_sock_handle_rx()` would simply return 0 when the timeslot was invalid instead of reporting an error.

To view, visit change 42421. To unsubscribe, or for help writing mail filters, visit settings.