Attention is currently required from: daniel, lynxis lazus, pespin.

View Change

1 comment:

• File src/tcap_as_loadshare.c:

  • Patch Set #2, Line 81: OSMO_ASSERT

    Might be worth checking if the ASN.1 decoder actually returns an error.

    exactly. And even if it does now under some circumstances implement those constraint checks in the decoder, that might change with future versions of asn1c. I think in general we should never assert for anything that relates to a received packet, whether in direct representation or some transformation like an asn1decode. We just treat the packet as invalid, log + rate_ctr that and continue to work as usual.

To view, visit change 42212. To unsubscribe, or for help writing mail filters, visit settings.