lynxis lazus submitted this change.
Gb/NS: SNS: SNS Ack don't add List of IP4/6 Elements on success.
The List of IP4/6 Elements should be only present on a SNS Ack
if the procedure fails with cause code Unknown IP Endpoint.
However ns2 code appended the List always to the SNS Ack.
Remove List of IP4/6 Elements from SNS Add, it can't fail with Unknown IP Endpoint.
Remove List of IP4/6 Elements from SNS Change Weight success case.
Related: OS#6611
Change-Id: If99b204a9d754323e53746b31bc13df53a653b7d
---
M src/gb/gprs_ns2_sns.c
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/gb/gprs_ns2_sns.c b/src/gb/gprs_ns2_sns.c
index 29ccfb0..4a9bb18 100644
--- a/src/gb/gprs_ns2_sns.c
+++ b/src/gb/gprs_ns2_sns.c
@@ -1268,7 +1268,7 @@
}
/* TODO: correct behaviour is to answer to the *same* NSVC from which the SNS_ADD was received */
- ns2_tx_sns_ack(gss->sns_nsvc, trans_id, NULL, v4_list, num_v4, v6_list, num_v6);
+ ns2_tx_sns_ack(gss->sns_nsvc, trans_id, NULL, NULL, 0, NULL, 0);
gprs_ns2_start_alive_all_nsvcs(gss->nse);
}
@@ -1440,7 +1440,8 @@
ns2_tx_sns_ack(gss->sns_nsvc, trans_id, &cause, NULL, 0, NULL, 0);
return;
}
- ns2_tx_sns_ack(gss->sns_nsvc, trans_id, NULL, v4_list, num_v4, v6_list, num_v6);
+
+ ns2_tx_sns_ack(gss->sns_nsvc, trans_id, NULL, NULL, 0, NULL, 0);
}
static void ns2_sns_st_configured(struct osmo_fsm_inst *fi, uint32_t event, void *data)
To view, visit change 39062. To unsubscribe, or for help writing mail filters, visit settings.