Attention is currently required from: laforge.
Patch set 3:Code-Review -1
3 comments:
Patchset:
I have the feeling that file2pe method might bear a risk to cause inconsistencies.
File pySim/esim/saip/__init__.py:
Patch Set #3, Line 636: def file2pe(self, f: File):
Maybe replace "f" with "file" to make it more uniform to the add_file method?
Patch Set #3, Line 638: self.decoded[f.pe_name] = f.to_tuples()
There is something I am struggling with. There is already the add_file() method. This method adds files to self.files and does a couple of other things as well. When we now use file2pe to put a file from whatever source into self.decoded. Then the rest of the class members (self.files, etc.) know nothing about the update. For example, the next time we run files2pe, the updated file gets overwritten with the old content. Maybe we need a more elaborated update function, similar to add_file?
To view, visit change 41734. To unsubscribe, or for help writing mail filters, visit settings.