Attention is currently required from: pespin.

View Change

3 comments:

• File src/Makefile.am:

  • Patch Set #8, Line 13: ss7_as_loadshare_tcap_vty.h \

    tcap_loadshare_vty.{c,h}? […]

    No, I have static inline functions which no-ops, when the feature is not used. IMHO: this keeps the code cleaner, because it reduces the amount of #ifdef/#endif in the code.

• File src/ss7_as_loadshare_tcap_vty.h:

  • Patch Set #8, Line 6: #ifdef WITH_TCAP_LOADSHARING

    Drop this, simply only include the header when ifdef BUILD_WITH_TCAP_LOADSHARING

    No, I like to have static inlines instead if the feature isn't enabled.

• File src/ss7_as_loadshare_tcap_vty.c:

  • Patch Set #8, Line 50: "show cs7 instance <0-15> as tcap-ranges name AS_NAME",

    are we using the same ordering in other vty command? looks weird ot have "as", then "tcap-ranges" an […]

    @dwillmann@sysmocom.de?

To view, visit change 41311. To unsubscribe, or for help writing mail filters, visit settings.