Attention is currently required from: fixeria, jolly, laforge.
jolly uploaded patch set #5 to this change.
The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder
Check for protocol extension bit in message type at a central location
Bits 8 and 7 of message type can be used as sequence number or have
specific default values. The added check will verify the bits according
to the prococol descriptor and Release version.
The Rules for these bits are described in GSM TS 124.007, clause
11.2.3.2.1 for Release <= 98 and 11.2.3.2.2 for Release >= 99.
There is also no need to clear bit 7 in message type for these
protocols, as it is done already in gsm48_hdr_msg_type().
Some unit tests fail without fixes that are included in this patch.
Change-Id: Iae41bc6a2e9fd85583509b6c6154dd5a935fb5df
---
M src/libmsc/gsm_04_08_cc.c
M src/libmsc/msc_a.c
M src/libmsc/msc_vgcs.c
M tests/msc_vlr/msc_vlr_test_authen_reuse.c
M tests/msc_vlr/msc_vlr_test_call.c
M tests/msc_vlr/msc_vlr_test_gsm_ciph.c
M tests/msc_vlr/msc_vlr_test_umts_authen.c
M tests/msc_vlr/msc_vlr_tests.c
M tests/msc_vlr/msc_vlr_tests.h
9 files changed, 64 insertions(+), 10 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/79/38579/5
To view, visit change 38579. To unsubscribe, or for help writing mail filters, visit settings.