Attention is currently required from: daniel, jolly.

View Change

1 comment:

• Commit Message:

  • Patch Set #1, Line 9:

    Let's return an error if both osmo_iofd_setup() and osmo_iofd_register()
    are called with an invalid file descriptor like -1.
    

    I see the check for osmo_iofd_register(), but not for osmo_iofd_setup() in this patch.

    at osmo_iofd_setup() time it is legal to pass -1. Only at osmo_iofd_register() time we can perform a check. Either iofd->fd is already set from the prior osmo_iofd_setup() call (good) or we have been give a valid fd as argument (good). But if neither of those two were valid (>= 0) then we have to bail out here.

To view, visit change 36188. To unsubscribe, or for help writing mail filters, visit settings.