Attention is currently required from: daniel, fixeria, laforge, osmith.

1 comment:

Patchset:
- Patch Set #1:
  @laforge@gnumonks.org I don't even get why we have the "round-robin" traffic mode (OSMO_SS7_AS_TMOD_ROUNDROBIN), it doesn't even show up in RFC4666, so it cannot be requested over the wire....
  I think this ended up as a confusion. The "round-robin" thing afaiu is actually one of the possible implementations of the "loadshare" traffic mode.
  Hence, imho we should:
  1- remove the OSMO_SS7_AS_TMOD_ROUNDROBIN field and remove it from "traffic-mode" VTY command too.
  2- Add a new "enum osmo_ss7_as_traffic_loadshare_impl" where we have enum fields "SLS" and "ROUNDROBIN", and then in the vty command "loadshare" (see https://gerrit.osmocom.org/c/libosmo-sigtran/+/39408/6/src/osmo_ss7_vty.c, following Cisco ITP) add a new "traffic-mode loadshare round-robin" (also as specified in Cisco ITP).
  
  So basically, rounrobin vs SLS distributon are options of the "loadshare" traffic mode.
  I plan to provide those patches on top of the ASP loadsharing patchset unless somebody has any other opinion.

To view, visit change 39650. To unsubscribe, or for help writing mail filters, visit settings.