Attention is currently required from: daniel, dexter, laforge.

View Change

3 comments:

• File contrib/csv-to-pgsql.py:

  • Patch Set #5, Line 38: table_name

    Maybe do the `self.table = lower(table_name)` here to avoid doing this in each query?

  • Patch Set #5, Line 132: %s;", (self.table.lower(),))

    Why not using `SQL("...").format(...)` here like you do above?

• File setup.py:

  • Patch Set #4, Line 37: psycopg2-binary

    What if we leave it out and mention it in the manual that it is needed

    when someone wants to use the CardKeyProviderPgsql? Would that be an option?

    This is indeed an option. Also, we do have `extras_require` below - this is where you can specify optional dependencies. You would also need to take care of importing the `psycopg2` not globally, but in a specific place (e.g. during the class instance instantiation).

To view, visit change 41508. To unsubscribe, or for help writing mail filters, visit settings.