Attention is currently required from: kirr.

View Change

1 comment:

• File src/target/trx_toolkit/transceiver.py:

  • Patch Set #1, Line 315: self._tx_queue_lock.acquire()

    It should be faster if you would do this as 3x list comprehensive:

        drop = [msg for msg in self._tx_queue if msg.fn < fn]
        emit = [msg for msg in self._tx_queue if msg.fn == fn]
        wait = [msg for msg in self._tx_queue if msg.fn > fn]

    
    I did a short benchmark:

    1024: lcomp 4.5777000000000006e-05
    1024: forloop 0.00022187000000000002
    100: lcomp 6.552e-06
    100: forloop 2.3484e-05
    10: lcomp 2.6650000000000003e-06
    10: forloop 6.582000000000001e-06
    1: lcomp 1.6030000000000002e-06
    1: forloop 2.3440000000000003e-06

    
    https://gist.github.com/lynxis/b75bb8426ec9ae7a487527b5258e4358

To view, visit change 39534. To unsubscribe, or for help writing mail filters, visit settings.