Attention is currently required from: falconia, pespin.
Patch set 2:Code-Review +1
5 comments:
Commit Message:
by emitting two RTP packets
directly back-to-back for UL, and pulling two RTP packets at a time
from the Rx jitter buffer at the needed times for DL.
I understand your idea now. Just curious, how would you do that if osmo-bts were an E1 BTS (not Abis-over-IP)? I guess the only option would be to buffer V.110 frames, since you cannot do the same trick for a TDM interface.
File src/common/l1sap.c:
Patch Set #2, Line 1493: /* TDMA frame number of burst 'a' % 26 is the table index.
This bit of code is not newly written with this patch - I simply moved it from osmo-bts-trx to the c […]
I agree with Mychaela here. It's a well known constant that is used quite often here and there.
`ARRAY_SIZE(input_msg)` here and below, please.
I would put a comment that it's an IDLE frame (all bits set to 1).
Patch Set #2, Line 2098: switch (lchan->tch_mode) {
As a further improvement, I suggest sharing `csd_v110_lchan_desc[]`, so that it can be used here (`desc->num_blocks * desc->num_bits`). I have a WIP patch moving that lookup table to libosmocore: https://gerrit.osmocom.org/c/libosmocore/+/35914.
To view, visit change 38553. To unsubscribe, or for help writing mail filters, visit settings.