Attention is currently required from: osmith, fixeria.

View Change

1 comment:

• File src/gprs/gprs_llc_parse.c:

  • Patch Set #1, Line 138: ghp->data = (uint8_t *)&ctrl[3];

    The main point of using const is *not* to assist the compiler in optimizations but to protect yourse […]

    You are also telling the user that calling the function won't make any kind of modification at any time to contents of that address at any time. What if the user passes a const pointer coming from a write-protected memory region?

    Yes, you are supposed, according to your change API, to store a *readonly* address, not a write one.

To view, visit change 29279. To unsubscribe, or for help writing mail filters, visit settings.