dexter has uploaded this change for review.

View Change

pySim/ts_51_011: rewrite comment for better understanding

The comment reads like that we were applying TS 102.221 here, but we only
mean our internal decoding format. The spec that actually matters here is
TS 51.011. Let's rephrase the comment so that this becomes more clear.

Related: OS#7018
Change-Id: Ie0184eea25f4d9f4baf9ab137c53a926edba2bf8
---
M pySim/ts_51_011.py
1 file changed, 5 insertions(+), 3 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/71/42771/1

diff --git a/pySim/ts_51_011.py b/pySim/ts_51_011.py
index 89ff824..4cad049 100644
--- a/pySim/ts_51_011.py
+++ b/pySim/ts_51_011.py
@@ -1263,9 +1263,11 @@
 
     @staticmethod
     def decode_select_response(resp_hex: str) -> object:
-        # we try to build something that resembles a dict resulting from the TLV decoder
-        # of TS 102.221 (FcpTemplate), so that higher-level code only has to deal with one
-        # format of SELECT response
+        """
+        Decode the select response to a dict representation, similar to the one of TS 102.221 (see ts_102_221.py,
+        class FcpTemplate), so that higher-level code only has to deal with one respresentation. See also
+        3GPP TS 51.011, section 9.2.1
+        """
         resp_bin = h2b(resp_hex)
         struct_of_file_map = {
             0: 'transparent',

To view, visit change 42771. To unsubscribe, or for help writing mail filters, visit settings.