Attention is currently required from: jolly.

Patch set 1:-Code-Review

View Change

1 comment:

• File src/ipa/libipa/proc_prfle_inst.c:

  • Patch Set #1, Line 45: ipa_es10b_immediate_enable(ctx);

    (this refers to WIP: Add refreshFlag, read the review comments there first)

    Here you would pass the refreshFlag together with the (aforementioned) req struct. Use the configured refreshFlag from ctx->cfg->refresh_flag.

    
    (please do not greb the refresh_flag from inside ipa_es10b_immediate_enable, I guess the architecture is a bit unclean here. However, since the refreshFlag is a an input parameter of the ES10b function call, it must be passed through a req parameter.)

    (It is also a bit vague what exactly grants the immediate profile enable, I guess when the immediateEnableFlag is not set inside the eUICC, immediateEnable is not granted.)

To view, visit change 43025. To unsubscribe, or for help writing mail filters, visit settings.