Attention is currently required from: laforge, pespin.
1 comment:
Commit Message:
The ipaccess OML bts_nr is still kept as uint8_t so nothing changes over
the wire. That's because in ipaccess OML, in general each BTS is
bt
Which other BTSs are we speaking about which are not ip.access connecting to osmo-bsc? Ericsson om2k? nokia foobar?
Yes, these. Check `enum gsm_bts_type`.
I don't know tbh, One would needs to check if those have some sort of limitation ...
At least a quick git-grep shows me that `bts->nr` is sent over the wire in the om2k, for instance:
```
src/osmo-bsc/abis_om2000.c:3189: om2k_mo_init(&trx->rbs2000.trxc.om2k_mo, OM2K_MO_CLS_TRXC, bts->nr, 255, trx->nr);
src/osmo-bsc/abis_om2000.c:3192: om2k_mo_init(&trx->rbs2000.tx.om2k_mo, OM2K_MO_CLS_TX, bts->nr, 255, trx->nr);
src/osmo-bsc/abis_om2000.c:3195: om2k_mo_init(&trx->rbs2000.rx.om2k_mo, OM2K_MO_CLS_RX, bts->nr, 255, trx->nr);
src/osmo-bsc/abis_om2000.c:3200: om2k_mo_init(&ts->rbs2000.om2k_mo, OM2K_MO_CLS_TS, bts->nr, trx->nr, i);
src/osmo-bsc/abis_om2000.c:3217: om2k_mo_init(&bts->rbs2000.cf.om2k_mo, OM2K_MO_CLS_CF, bts->nr, 0xFF, 0);
src/osmo-bsc/abis_om2000.c:3220: om2k_mo_init(&bts->rbs2000.is.om2k_mo, OM2K_MO_CLS_IS, bts->nr, 0xFF, 0);
src/osmo-bsc/abis_om2000.c:3223: om2k_mo_init(&bts->rbs2000.con.om2k_mo, OM2K_MO_CLS_CON, bts->nr, 0xFF, 0);
src/osmo-bsc/abis_om2000.c:3226: om2k_mo_init(&bts->rbs2000.dp.om2k_mo, OM2K_MO_CLS_DP, bts->nr, 0xFF, 0);
src/osmo-bsc/abis_om2000.c:3228: om2k_mo_init(&bts->rbs2000.tf.om2k_mo, OM2K_MO_CLS_TF, bts->nr, 0xFF, 0);
src/osmo-bsc/abis_om2000.c:3231: om2k_mo_init(&bts->rbs2000.mctr.om2k_mo, OM2K_MO_CLS_MCTR, bts->nr, 0xFF, 0);
```
This looks like a problem to me, given the definition of `struct abis_om2k_mo`:
```
551 /* Ericsson OM2000 Managed Object */
552 struct abis_om2k_mo {
553 uint8_t class;
554 uint8_t bts;
555 uint8_t assoc_so;
556 uint8_t inst;
557 } __attribute__ ((packed));
```
Harald definitely knows more about om2k, I am just raising a concern, which is specifically about non-ip.access BTS models osmo-bsc also supports.
To view, visit change 38052. To unsubscribe, or for help writing mail filters, visit settings.