Attention is currently required from: laforge.

View Change

2 comments:

• File src/osmo-bsc/nm_bb_transc_fsm.c:

  • Patch Set #2, Line 56: }

    the point is if teh function is prefixed nm_obj_* and you don't want to change the function name, th […]

    nm_obj here is used in the sense of "The NM Object this FSM is handling", which is a bb_transc in this case. So it's based on the context of the current FSM, the function is static/internal/private after all. There's no such "struct nm_obj" at all.
    This way when these functions are used in each FSM state function, they look a lot similar, so it's easy to follow the FSM logic more easily, and see that all basically do the same, each on the NM object they are managing.
    But if this really causes trouble to you I'll change the name and be done with it, though I really prefer it the way it is now.

• File src/osmo-bsc/nm_rcarrier_fsm.c:

  • Patch Set #2, Line 43: static void nm_obj_becomes_enabled_disabled(struct gsm_bts_trx *trx, bool running)

    then pass some generic object and have the called function use gsm_objclass2obj() to de-reference th […]

    ACK I'll change the function name.

To view, visit change 28046. To unsubscribe, or for help writing mail filters, visit settings.