pespin has uploaded this change for review.

View Change

mgw: Remove wrong TODO comment

The TODO was written because the author had in mind the ptr where the
codec was stored was a MGCP endpoint object, but it is actually an
rtp_end which is an object under conn_rtp, so that's fine already with
current code.

Change-Id: I99d2211e81443883c45cc3fdda10e39a8c152063
---
M src/libosmo-mgcp/mgcp_protocol.c
1 file changed, 0 insertions(+), 1 deletion(-)

git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/49/39249/1

diff --git a/src/libosmo-mgcp/mgcp_protocol.c b/src/libosmo-mgcp/mgcp_protocol.c
index dca98a2..46c6815 100644
--- a/src/libosmo-mgcp/mgcp_protocol.c
+++ b/src/libosmo-mgcp/mgcp_protocol.c
@@ -1182,7 +1182,6 @@
 		goto error3;
 	}
 	/* Upgrade the conn type RTP_DEFAULT->RTP_IUUP if needed based on requested codec: */
-	/* TODO: "codec" probably needs to be moved from endp to conn */
 	if (conn_rtp->type == MGCP_RTP_DEFAULT &&
 	    strcmp(conn_rtp->end.cset.codec->subtype_name, "VND.3GPP.IUFP") == 0)
 		rc = mgcp_conn_iuup_init(conn_rtp);

To view, visit change 39249. To unsubscribe, or for help writing mail filters, visit settings.