Attention is currently required from: pespin.

View Change

2 comments:

• File src/common/l1sap.c:

  • Patch Set #2, Line 1891: case PL_DECISION_ACCEPT_ASIS:

    I'd rather drop the "ASIS" part from here, it is confusing, it looks like some sort of acronym.

    Would PL_DECISION_ACCEPT_AS_IS be acceptable? Or do you prefer short and simple PL_DECISION_ACCEPT?

• File src/common/rtp_input_preen.c:

  • Patch Set #2, Line 37: static bool rtppayload_is_octet_aligned(const uint8_t *rtp_pl, unsigned payload_len)

    feel free to add "amr_is_octet_aligned" (add "amr") so that it vecomes clearer this is for AMR.

    Adding it to my mental notes for the next version.

To view, visit change 32988. To unsubscribe, or for help writing mail filters, visit settings.