Attention is currently required from: laforge, pespin, dexter.
3 comments:
Patchset:
I've verified this module's encryption and decryption against what SJA2 and one other SIM implementation.
Most comments are on an "it's not broken" level and could just as well be addressed later, but the PCNT should not get overlooked, so I'm leaving this at +1 until that is fixed to avoid accidental merging (if a +2 from me even carried the weight to make things mergable).
File pySim/ota.py:
Patch Set #5, Line 402: def decode_resp(self, otak: OtaKeyset, spi: dict, data: bytes) -> bytes:
`-> bytes` is currently inaccurate, should be `CompactRemoteResp` (but see below)
Patch Set #5, Line 452: return dec
There will need to be an API change later here, as in cases of `res.response_status == 'actual_response_sms_submit'`, we'll rather need the res (and the CompactRemoteResp parsing fails in these cases, currently) rather than the dec.
A concrete suggestion for a change is in I1c488a19ad75114255c8ff1c59d903388451b37a in the chrysn/for-29033 branch.
To view, visit change 29033. To unsubscribe, or for help writing mail filters, visit settings.