Attention is currently required from: dexter, laforge.
7 comments:
File contrib/generate_smdpp_certs.py:
To me this looks like an independent tool. […]
no, this is the tool and these are the options, these things belong together and make absolutely no sense as single commits with random mystery options and useless certs.
File osmo-smdpp.py:
Patch Set #5, Line 26: from pathlib import Path
You have moved a lot of those imports from another code location. […]
Done
We now support SSL and we have means to point to different certificate sub directories. […]
not related to this patch at all, we cann add stuff if we need it later.
Patch Set #5, Line 586: parser.add_argument("-p", "--port", help="TCP port to bind HTTP to", default=8000)
Maybe 8443, since we now support SSL?
no, because that is being used by something else on my system, we really do not want to default to a port commonly used for anything like https for a toy smdpp.
Patch Set #5, Line 587: parser.add_argument("-c", "--certpath", help=f"cert subdir relative to {DATA_DIR}", default="certs")
I think --certpath is a bit irritating as one may thing that it is possible to provide an absolute p […]
Done .. the help line literally explains that it is relative
Patch Set #5, Line 588: parser.add_argument("-s", "--nossl", help="do NOT use ssl", action='store_true', default=False)
I wonder if this may break anything when osmo-smdpp suddenly supports SSL by default. […]
The number of users is probably... low.. anyway.
Patch Set #5, Line 591: common_cert_path = os.path.join(DATA_DIR, args.certpath)
(see above) Maybe having DATA_DIR as a commandline parameter would be a good idea.
I dont't need it, and it is not related to this patch either.
To view, visit change 40464. To unsubscribe, or for help writing mail filters, visit settings.