Attention is currently required from: fixeria.

Patch set 5:Code-Review +1

View Change

2 comments:

• File include/s1gw_metrics.hrl:

  • Patch Set #3, Line 9: S1GW_CTR_S1AP_PROXY_IN_PKT

    This one was not referenced anywhere, so I removed it.

    ACK

• File src/sctp_proxy.erl:

  • Patch Set #4, Line 109: S1GW_CTR_S1AP_PROXY_UPLINK_PACKETS_QUEUED

    @pespin@sysmocom.de do we really want this as a counter? IMO, gauge alone would do the job. […]

    The fact that is not special doesn't really mean to me that we should not be counting it. Some counters actually showcase the good usual behavior of the program, like calls being established, etc.
    It can also be used for instance to get a glimpse on the amount of packets being forwarded over time, whether the traffic is bursty or not, etc.

To view, visit change 37955. To unsubscribe, or for help writing mail filters, visit settings.