Attention is currently required from: fixeria, pespin.
1 comment:
File gen_makefile.py:
for i in {build_proj}/default/bin/*; do \\
if [ -e "$$i" ]; then \\
install -v -Dm755 "$$i" -t {shlex.quote(args.install_prefix)}/bin/; \\
setup_gen
Oh interesting! Apparently this doesn't get created in default/bin when REBAR_BASE_DIR is set (as we do when using osmo-dev). But yeah it's not great to rely on that, let's find a better way.
`if grep -q "^install:" Makefile; then`
I would also have preferred this, but the problem is that the Makefile before https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40756 already has an install target, so this does not work.
However, how about we add an `install-osmo-dev: install` target to the Makefile to make it explicit what osmo-dev should do, and then check for that here? (`if grep -q "^install-osmo-dev:" Makefile; then`)
To view, visit change 40770. To unsubscribe, or for help writing mail filters, visit settings.