Attention is currently required from: jolly.

View Change

4 comments:

• File include/osmocom/bsc/vgcs_fsm.h:

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-9058):

    Patch Set #2, Line 59: /* Channel link failed. (Talker faild.) */

    'faild' may be misspelled - perhaps 'failed'?

• File src/osmo-bsc/vgcs_fsm.c:

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-9058):

    Patch Set #2, Line 373: LOG_CALL(conn, LOGL_DEBUG, "Calling subscriber assiged and now on uplink.\n");

    'assiged' may be misspelled - perhaps 'assigned'?

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-9058):

    Patch Set #2, Line 668: no_aoip:

    labels should not be indented

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-9058):

    Patch Set #2, Line 1155: strcpy(conn->vgcs_chan.msc_rtp_addr, req.msc_rtp_addr);

    Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY()

To view, visit change 33611. To unsubscribe, or for help writing mail filters, visit settings.