Attention is currently required from: laforge, osmith.
8 comments:
Patchset:
The approach I've taken with checkpatch (from linux. […]
clang-format formats and that is the end of it, no discussions, NOTHING EVER AGAIN.
That is the advantage and the reason why everyone uses a clang format file and why even the kernel has one, for the style we allegedly use, but clearly, we don't do that, and therefore we can didscuss formatting again and again and again...
File ccid_common/ccid_device.c:
Patch Set #1, Line 547: // break;
not useful IMHO. this is also in other places in this patch.
yeah but consistent and enforcable and easy to unindent after uncommenting the block.
File ccid_common/ccid_proto.h:
Patch Set #1, Line 366: #define CCID_CMD_STATUS_TIME_EXT 0x80
here and in enum ccid_error_code below, it is more readable to keep the values directly below each o […]
looks more aligned now
File ccid_common/ccid_proto.c:
Patch Set #1, Line 70: { CCID_ERR_CMD_ABORTED, "CMD_ABORTED" },
+1
this is the alignment of arrays of structs. its either left, right, or one long line that breaks at 120 chars. neither left nor right is more or less readable than the randomly indented version and an random long line is obviously even worse, but at least this is consistent and can be applied and checked.
File ccid_common/iso7816_3.c:
doesn't seem useful to reformat it like this?
it is definitely more readable than a sneaky semicolon at the end, and it's the kernel style we allegedly use...
File ccid_common/iso7816_fsm.c:
Patch Set #1, Line 168: static const uint8_t convention_convert_lut[256] = {
yeah, that looks like it's not intended.
fixed by telling clang-format to keep it like that
Patch Set #1, Line 818: .in_event_mask = S(ISO7816_E_RX_SINGLE) | S(ISO7816_E_RX_COMPL) | S(ISO7816_E_TX_COMPL) | S(ISO7816_E_RX_ERR_IND) | S(ISO7816_E_TX_ERR_IND) | S(ISO7816_E_TPDU_DONE_IND),
https://gerrit.osmocom. […]
fixed by telling clang-format to keep it like this
File sysmoOCTSIM/usb_descriptors.c:
this also clearly is not an improvement of readability at all.
Done
To view, visit change 42330. To unsubscribe, or for help writing mail filters, visit settings.