laforge submitted this change.

View Change

Approvals: Jenkins Builder: Verified laforge: Verified fixeria: Looks good to me, approved
bankd: Don't log an "Error" if slotmap is removed

removing a slotmap and the related client disconnect are perfectly
normal operation. Don't print the word Error in the log in such cases,
it just confuses the user.

Closes: OS#5629
Change-Id: Ie39d35fd348fdf3dd53c860dc830aac794a3ead5
---
M src/bankd/bankd_main.c
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/bankd/bankd_main.c b/src/bankd/bankd_main.c
index c2d6e69..b3b8dff 100644
--- a/src/bankd/bankd_main.c
+++ b/src/bankd/bankd_main.c
@@ -986,7 +986,10 @@
break;
}

- LOGW(g_worker, "Error %d occurred: Cleaning up state\n", rc);
+ if (rc == -23)
+ LOGW(g_worker, "Client unmapped: Cleaning up state\n");
+ else
+ LOGW(g_worker, "Error %d occurred: Cleaning up state\n", rc);

/* clean-up: reset to sane state */
memset(&g_worker->card, 0, sizeof(g_worker->card));

To view, visit change 28773. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: Ie39d35fd348fdf3dd53c860dc830aac794a3ead5
Gerrit-Change-Number: 28773
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge@osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-MessageType: merged