Attention is currently required from: arehbein, laforge, pespin.

View Change

2 comments:

• File src/stream_srv.c:

  • Patch Set #2, Line 489: if (OSMO_UNLIKELY(res <= 0)) {

    Why do we not call `osmo_stream_srv_clear_tx_queue()` here, if the connection is dead anyways?

    Because that's what osmo_stream_srv_destroy() does already (either through msgb_queue_free() or osmo_iofd_free())

  • Patch Set #2, Line 496: if (osmo_iofd_txqueue_len(iofd) == 0)

    Can it not happen that messages can't be sent out, so that this condition never holds true? In that […]

    I just noticed that osmo_stream_srv_clear_tx_queue() is not aware of osmo_io. I'll prepare a patch.

    We only end up here if there's actual data to be read, so it's not really an endless loop.

    The only way where a message is never sent out is if the fd never is writable. Even if sending then fails that message has been removed from the tx queue so it will eventually be empty.

To view, visit change 34338. To unsubscribe, or for help writing mail filters, visit settings.