Attention is currently required from: dexter, fixeria.

Patch set 4:Code-Review -1

View Change

1 comment:

• File pySim/transport/__init__.py:

  • Patch Set #4, Line 330: devinfo = "serial:%s" % opts.device

    I don't think that common code should contain clauses for each specific backend. that's a layering violation and sounds like we actually want this to be dispatched to methods of the specific transport?

To view, visit change 34693. To unsubscribe, or for help writing mail filters, visit settings.