Attention is currently required from: laforge.
View Change
1 comment:
File pySim-shell.py:
Patch Set #1, Line 974: raise RuntimeError("Cannot create (always existing) basic logical lchan 0")
Id'd have assumed raising a ValueError is more correct, as it's a wrong value. […]
I think restricting the value range at argparse level is the most effecting option.
To view, visit change 37839. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I4eebd9f15fadd18e1caeb033fda36c59446fcab8
Gerrit-Change-Number: 37839
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge@osmocom.org>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Comment-Date: Mon, 19 Aug 2024 15:02:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge@osmocom.org>