Attention is currently required from: laforge, pespin.

View Change

6 comments:

• File src/core/osmo_io_internal.h:

  • Patch Set #6, Line 116: /* ! array of rings the submitted read SQEs have been submitted */

    "have been submitted to"

    Done

• File src/core/osmo_io_uring.c:

  • Patch Set #6, Line 115: g_ring = calloc(1, sizeof(*g_ring));

    use talloc.

    Done

  • Patch Set #6, Line 164: LOGP(DLIO, LOGL_NOTICE, "increasing io_uring size to %d.\n", g_io_uring_size);

    Please put this into 1 single LOGP.

    Done

  • Patch Set #6, Line 172: sqe = io_uring_get_sqe(&g_ring->ring);

    so here we end up with 2 read SQEs on 2 different queues. […]

    I added a check, so subsequent read SQEs are never spread over different rings.

  • Patch Set #6, Line 527: while ((sqe = io_uring_get_sqe(iofd->u.uring.read_ring[idx])) == NULL);

    that looks like a really nice tight non-blocking loop filling the CPU?

    Done

  • Patch Set #6, Line 543: while ((sqe = io_uring_get_sqe(iofd->u.uring.write_ring)) == NULL);

    that looks like a really nice tight non-blocking loop filling the CPU?

    Done

To view, visit change 40725. To unsubscribe, or for help writing mail filters, visit settings.