pespin submitted this change.

View Change


Approvals: fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified pespin: Looks good to me, approved
Avoid using UL TBF in RELEASE state to assign DL TBF over PACCH

In RELEASE state, the UL TBF is considered not available anymore, and we
are simply waiting in order to be able to reuse the allocated resources
(just in case it was still around). Hence, a UL TBF in that state should
not be selectable to initiate a DL TBF assignment over PACCH.

Related: OS#5472
Change-Id: Ia11f7802779cfeea15a71bddad9f7e0c6c1afb11
---
M src/gprs_ms.c
1 file changed, 17 insertions(+), 1 deletion(-)

diff --git a/src/gprs_ms.c b/src/gprs_ms.c
index dda2f29..06d012c 100644
--- a/src/gprs_ms.c
+++ b/src/gprs_ms.c
@@ -1106,7 +1106,8 @@
if (!ul_tbf)
return true;
if (ul_tbf_contention_resolution_done(ul_tbf) &&
- !tbf_ul_ack_waiting_cnf_final_ack(ul_tbf))
+ !tbf_ul_ack_waiting_cnf_final_ack(ul_tbf) &&
+ tbf_state(ul_tbf_as_tbf(ul_tbf)) != TBF_ST_RELEASING)
return true;

return false;

To view, visit change 33453. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ia11f7802779cfeea15a71bddad9f7e0c6c1afb11
Gerrit-Change-Number: 33453
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-MessageType: merged