laforge submitted this change.

View Change

Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved jolly: Looks good to me, but someone else must approve
asn1: ber_decoder: disable stack size check on ctx = NULL

The stack size check is triggering when using asan or
when compile with -O1.
It is unclear why this is problematic.
This is a not a leak.

Related: OS#7002
Change-Id: Id99531f62ccdf73497bb08483ca6adbabe1a7cd7
---
M src/rspro/ber_decoder.c
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/rspro/ber_decoder.c b/src/rspro/ber_decoder.c
index 0f99400..1e150ac 100644
--- a/src/rspro/ber_decoder.c
+++ b/src/rspro/ber_decoder.c
@@ -44,7 +44,9 @@
} else {
/* If context is not given, be security-conscious anyway */
memset(&s_codec_ctx, 0, sizeof(s_codec_ctx));
- s_codec_ctx.max_stack_size = _ASN_DEFAULT_STACK_MAX;
+ /* TODO: disable stack check until the root cause can be debugged. See OS#7002
+ s_codec_ctx.max_stack_size = _ASN_DEFAULT_STACK_MAX; */
+ s_codec_ctx.max_stack_size = 0;
opt_codec_ctx = &s_codec_ctx;
}


To view, visit change 42706. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: merged
Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: Id99531f62ccdf73497bb08483ca6adbabe1a7cd7
Gerrit-Change-Number: 42706
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis@fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly <andreas@eversberg.eu>
Gerrit-Reviewer: laforge <laforge@osmocom.org>