Attention is currently required from: wbokslag.

View Change

2 comments:

• File src/crypto/tetra_crypto.c:

  • Patch Set #2, Line 207:

    	case KSG_TEA1:
    		tea1_stub(iv, eck, num_bytes, ks_bytes);
    		break;
    	case KSG_TEA2:
    		tea2_stub(iv, eck, num_bytes, ks_bytes);
    		break;
    	case KSG_TEA3:
    		tea3_stub(iv, eck, num_bytes, ks_bytes);
    		break;
    

    I think it's a bit weird to add the stub functions that don't do anything in a commit here. This leads to situations that if somebody calls the function now, it returns success (true) despite not having generated the keystream. I think it would be wise to not merge the stub functions at all, and have generate_keystream run into the default-clause below which gives a proper error message and return code instead of silent failure.

  • Patch Set #2, Line 305: /

    we typically prefer /* */ comments. Feels especially inconsistenc since this very same patch is adding multiple comments in different styles.

To view, visit change 34001. To unsubscribe, or for help writing mail filters, visit settings.