Attention is currently required from: fixeria, lynxis lazus.

View Change

3 comments:

• File include/osmocom/gsm/protocol/gsm_04_08_gprs.h:

  • Patch Set #1, Line 316: uint8_t organization:4, /* enum gsm48_pdp_type_org */

    alignment issues

    Ack

  • Patch Set #1, Line 337: uint32_t v4;

    likewise, alignment issues

    Ack

  • Patch Set #1, Line 340: ietf

    So the total size of this union is 20 (determined by size of `v4v6`). […]

    Yeah you cannot do that, but I don't see it being a problem. I already introduced/used this kind of packed struct in open5gs and I found it quite useful, I tink it really makes sense to have it here.

To view, visit change 35625. To unsubscribe, or for help writing mail filters, visit settings.