Attention is currently required from: fixeria, dexter.

View Change

2 comments:

• File pySim/transport/__init__.py:

  • Patch Set #4, Line 57: receive_fetch

    Rather decorate with @abc.abstractmethod, no need to raise NotImplementedError.

    the point here is that you don't neccessarily need to provide a receive_fetch method in your derived class. you only need it _if_ you don't implement the various handle_xxx methods. That's why I did it this way.

  • Patch Set #4, Line 164: while

    Could you explain why are you changing 'if' to 'while'?

    the existing code only handled one proactive response, and then interjected the FETCH command. However, if that FETCH command again reuslts in a 91xx response, it means there's another proactive command pending, and we need to do another FETCH, and repeat.

    This could/should have been a separate patch, but given that nobody is using the code yet, and the entire proactive support is pretty much WIP, I thought I can avoid creating even more one-line commits.

To view, visit change 28963. To unsubscribe, or for help writing mail filters, visit settings.