Attention is currently required from: Hoernchen, fixeria, laforge, pespin.

View Change

1 comment:

• File Transceiver52M/Transceiver.cpp:

  • Patch Set #10, Line 1132: msgLen = read(mDataSockets[chan], buffer, sizeof(buffer));

    You should instead properly split read/write from/to sockets into its own method.

    Could you please clarify if I understood you correctly?

    Do you mean that the socket read/write operations should be split into separate methods, and then overridden in the WebSDR subclass so that, instead of operating on sockets, they would operate on some intermediate buffers?

    That approach should work, and architecturally it would probably look cleaner. My concern is that in the WebSDR case this would require placing the data into an intermediate buffer before calling method, as example driveTxPriorityQueue, and then reading it back here, which introduces an extra copy and may negatively affect performance.

    Is that the direction you had in mind?

To view, visit change 42411. To unsubscribe, or for help writing mail filters, visit settings.