Attention is currently required from: pespin.

View Change

6 comments:

• File src/twrtp.c:

  • Patch Set #7, Line 304: close(rtcp_fd);

    if (rtcp_fd >= 0) […]

    Done

  • Patch Set #7, Line 313: close(rtcp_fd);

    if (rtcp_fd >= 0) […]

    Done

  • Patch Set #7, Line 322: close(rtcp_fd);

    if (rtcp_fd >= 0) […]

    Done

  • Patch Set #7, Line 333: close(rtcp_fd);

    if (rtcp_fd >= 0) […]

    Done

  • Patch Set #7, Line 343: close(rtcp_fd);

    if (rtcp_fd >= 0) […]

    Done

  • Patch Set #7, Line 348: return 0;

    You could add return goto tags here for failing cases to make closing/freeing more organized and cle […]

    I am not smart enough to find a way to do it cleanly. In some error exit paths we need to explicitly close the passed fd, yet in others the closing is done by `osmo_iofd_free()`. Doing an extra `close()` after `osmo_iofd_free()` could create a race condition in multi-threaded applications: what if some other thread opens a new file or socket etc and gets the same fd.

    Can you accept Patchset 8 as it stands?

To view, visit change 39281. To unsubscribe, or for help writing mail filters, visit settings.