Attention is currently required from: jolly.

View Change

1 comment:

• File tests/testsuite.at:

  • Patch Set #7, Line 32: AT_CHECK([python3 -u $abs_top_builddir/tests/vty/vty_test_runner.py -w $abs_top_builddir -p $abs_srcdir -v TestDSCP],, [ignore], [ignore])

    merging this now as-is, we can always change the way we execute a test after it has been merged.

    I think it's fundamentally wrong to merge this as is since now afaiu make check needs osmo-python or whatever to work properly, which may in turn need more stuff in the system to run them, etc. and which in turn will may people run less make check.

    
    This is a uuser-facing feature, and hence afaiu should be tested when using the make target like vty or ext-tests or whatever, not tested during unit test phase.

    So I still think this needs to be changed as mentioned.

To view, visit change 42809. To unsubscribe, or for help writing mail filters, visit settings.