Attention is currently required from: falconia, fixeria.
1 comment:
Patchset:
> Alternatively, we may clarify the API docs and state that it's responsibility of the caller to [ze […]
I agree the current situation is not good API design - but we have been doing it this way [here] for a long time. Your patch now means we zero-initialize twice (the implicit memset in talloc_zero and the explicit one here). Shouldn't hurt performance as the data should be in cache after the first write, but still it's suboptimal. We also have no way of removing the memset in the existing code, as we have to keep forward/backward compatibility.
All in all it's dissatisfactory either way. But safety first, so I think we should merge this.
To view, visit change 38138. To unsubscribe, or for help writing mail filters, visit settings.