Attention is currently required from: pespin.

View Change

4 comments:

• File include/osmocom/gprs/rlcmac/tbf_dl.h:

  • Patch Set #5, Line 9: //#include <osmocom/gprs/rlcmac/tbf_dl_fsm.h>

    What's the point of commented include? Just drop it if it's unused.

  • Patch Set #5, Line 16: //struct gprs_rlcmac_tbf_dl_fsm_ctx state_fsm;

    Same here.

• File src/rlcmac/rlcmac.c:

  • Patch Set #5, Line 278: OSMO_ASSERT(bv);

    I think so far common practice was to log memory allocation errors and shutdown gracefully. Why the use of assert in here?

• File src/rlcmac/tbf_dl.c:

  • Patch Set #5, Line 37: //rc = gprs_rlcmac_tbf_dl_fsm_constructor(dl_tbf);

    That looks odd. Is this an artifact from patch split?

To view, visit change 31286. To unsubscribe, or for help writing mail filters, visit settings.