Attention is currently required from: daniel, dexter, jolly, pespin.
Patch set 8:Code-Review +1
1 comment:
Patchset:
I don't get it. osmo_iofd_setup is somtehing you call once for allocation and configuration. […]
ok, so normally osmo_stream_cli_create() should be calling osmo_iofd_setup(). In osmo_stream_cli_open() we should only call osmo_iofd_register(). That way we could do any number of open/close (vs. register/unregister) cycles without having to allocate a new iofd.
The reason we're not using osmo_iofd as it is expected to use is probably because in osmo_stream_cli_create() we don't yet know the mode, and hence don't know if we should go the osmo_fd or the osmo_iofd route.
Therefore we need to work-around this by doing osmo_iofd_setup() every time we go through osmo_stream_cli_open() - and hence we also need to free it. Sad, but we need to work around the mode not being known earlier. We might add some comments to explain the unusual use of osmo_iofd
To view, visit change 35979. To unsubscribe, or for help writing mail filters, visit settings.