Attention is currently required from: pespin.

Patch set 1:Code-Review +1

View Change

1 comment:

• File src/stream_srv.c:

  • Patch Set #1, Line 834: static int _sctp_recvmsg_wrapper(int fd, struct msgb *msg)

    the problem I always had with this function that it doesn't differentiate the log level based on the kind of event/notification.

    For example, I would say "SEND FAILED or "SHUTDOWN" are even worth NOTICE, but given that we use LOGPC we cannot change the log level of the prefix printed in the LOGP.

    Changing everything to INFO is the right direction, of course.

    One might argue everything except "UP" is NOTICE. But then it's awkward if you have level notice set and you see only the disconencts but never the new connects...

To view, visit change 34081. To unsubscribe, or for help writing mail filters, visit settings.