Attention is currently required from: neels.
10 comments:
Commit Message:
BSC ?
Done
fun?? =)
Done
File src/ericsson-rbs/er_ccu_if.c:
Patch Set #13, Line 62: /* called by trau frame synchronizer: feed received MAC blocks into PCU */
does it make sense to document who calls the function? usually we just describe what it does?
There are multiple callbacks in this c file used by different entities (->demux->synchronizer->) I think the comment helps to make sense since it helps to follow the path better.
Patch Set #13, Line 76: multeiplexer
multiplexer
Done
Patch Set #13, Line 90: multeiplexer
i
Done
Patch Set #13, Line 99: Function to
(drop the first two words)
Done
(nicer to start a new line for osmo_hexdump)
I think its better to have it in one line. I agree its a bit long but too many lines also make the log more difficult to read. Especially when grepping for things.
Patch Set #13, Line 143: (line=%u,ts=%u)
seems this log context occurs in several places, welcome a LOG_FOO() macro instead of code dup. […]
There is already a LOGPCCU. (line=%u,ts=%u) is only used three times where I couln'd use LOGPCCU.
"Note"? =)
Done
Patch Set #13, Line 184: /* NOTE: This is a serious error: subslots should be removed when l1if_close_pdch() is called by the PCU. This
(seems this comment wants to be inside the if { .. } body.) […]
Done
To view, visit change 31176. To unsubscribe, or for help writing mail filters, visit settings.