Attention is currently required from: jolly, laforge, fixeria.

View Change

1 comment:

• File msc/BSC_ConnectionHandler.ttcn:

  • Patch Set #2, Line 68: inout charstring, CallParameters, ASCI_Event;

    I would go the other way around: Why are there strings at all, and not more specific types going thr […]

    the messages being passed over COORD are in general quite test-specific, and the port shouldn't be seen as a regular protocol-defined port, but simply some sort of synchronization method imho, hence why simply using strings is enough and makes stuff simpler imho.

    The problem with string typos can easiler be solved by definiting const string variables, or enums and converting them enum2str() when sending.

    That being said, if others prefer ending up with several unrelated record types being transmitted over that same port I won't be blocking it despite disagreeing in principle.

To view, visit change 33979. To unsubscribe, or for help writing mail filters, visit settings.