Attention is currently required from: fixeria.

View Change

1 comment:

• File pySim/legacy/ts_51_011.py:

  • Patch Set #3, Line 7: """ Various constants from 3GPP TS 51.011 used by *legacy* code only.

    I don't have a strong opinion here, but the fact that these definitions are used by legacy code only […]

    the point is that nobody should use those incomplete data types here anymore. They do not reflect the hierarchical nature of the filesystem, but put all kinds of DFs in a flat dict. Likewise, they are certainly ages behind 3GPP specs.

    New code should make use of the pySim.filesystem class hierarchy to navigate the filesystem, select files, etc.

    It's never a good idea to have information duplicated in several locations in one code base.

    I would actually love to delete all this code, but there are still tons of users of the equally crufty pySim-prog. Eventually I might spend time re-implementing a saner version of pySim-prog not using any of the definitions here, but time/availability is of course a constraint.

To view, visit change 33693. To unsubscribe, or for help writing mail filters, visit settings.