Attention is currently required from: fixeria.

2 comments:

File include/osmocom/gsm/gsm0808_utils.h:
- Patch Set #1, Line 115: OSMO_DEPRECATED("use gsm0808_enc_speech_codec2() instead")
  It's the first time I see such a suggestion/requirement. […]
  i usually read .h files, and spotting the difference between two function versions goes a lot quicker when something explains it. IMO adding a few words can only improve it, but you do also explain in the API doc. so up to you.
File src/gsm/gsm0808_utils.c:
- Patch Set #1, Line 299: \a
  This is not directly related to this patch, but could you explain why?
  see the post linked at https://osmocom.org/projects/cellular-infrastructure/wiki/Guidelines_for_API_documentation#Parameters
  good that i read this again, '\a' is actually not wrong, it just puts the next word in italics. it's just my personal opinion that we should not use \a, for KISS.

To view, visit change 30574. To unsubscribe, or for help writing mail filters, visit settings.