dexter has uploaded this change for review.
eIM_Tests: remove code dup in f_esipa_transceive
In f_esipa_transceive we check if the response returned from
f_esipa_receive is the one we expect. But we can also pass the
expected response template to f_esipa_receive and let
f_esipa_receive perform the check.
Change-Id: I11f0b7bcf1bf8c763e6915eda34c3ede2a9a5c94
Related: SYS#8203
---
M eim/eIM_Tests.ttcn
1 file changed, 1 insertion(+), 7 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/20/43820/1
diff --git a/eim/eIM_Tests.ttcn b/eim/eIM_Tests.ttcn
index 7888885..723731c 100644
--- a/eim/eIM_Tests.ttcn
+++ b/eim/eIM_Tests.ttcn
@@ -480,13 +480,7 @@
runs on eIM_ConnHdlr return template EsipaMessageFromEimToIpa {
var template EsipaMessageFromEimToIpa esipa_res
f_esipa_send(esipa_req);
- esipa_res := f_esipa_receive();
- if (not istemplatekind(expected_esipa_res, "omit")) {
- if (not match(valueof(esipa_res), expected_esipa_res)) {
- setverdict(fail, "unexpected response from eIM on ESipa");
- }
- }
- return esipa_res;
+ return f_esipa_receive(expected_esipa_res);
}
To view, visit change 43820. To unsubscribe, or for help writing mail filters, visit settings.