Attention is currently required from: pespin.

Patch set 1:Code-Review -1

View Change

4 comments:

• File library/GTPv1U_Templates.ttcn:

  • Patch Set #1, Line 58: template (value)

    What do we win by doing so? IMO, template parameters are useful for complex parameters, like records and unions, as you can init some/all of their fields in a template. But for parameters of simple types like OCT or INT, I don't really see the benefits of doing so. One thing I can think of is allowing to pass multiple values, like `msg_type := (MSGT_FOO, MSGT_BAR)`, but this makes no sense for a send template.

  • Patch Set #1, Line 61: template (value) GTPU_IEs ies

    It's fine making this one a template param, so that you can pass templates like `ts_UEchoReqPDU` directly without having to use `valueof()`. But I am not sure about the other params.

  • Patch Set #1, Line 122: valueof(ts_UEchoReqPDU

    ... so you turned this param into a template, but still doing unnecessary `valueof()`.

  • Patch Set #1, Line 145: valueof(ip_addr)

    ... see, you expect a value here anyway, so why adding additional transformations to a template and then back to a value?

To view, visit change 37645. To unsubscribe, or for help writing mail filters, visit settings.