Attention is currently required from: laforge, pespin, fixeria.

View Change

2 comments:

• Commit Message:

  • Patch Set #1, Line 26:

    there is no legacy vty_go_parent() function that sets the correct
      index via a switch().
    

    note: Some of them cannot be dropped since they are used as hooks to do stuff like applying the new […]

    yes, for example in cs7 config, the go_parent_cb() does the action of applying config changes.

    But we can definitely get rid of all the *unnecessary* go_parent_cb()s, and all go_parent code that merely sets vty->node to a new constant. I've been doing that here and there over the years already...

• File tests/vty/vty_transcript_test.c:

  • Patch Set #1, Line 344: talloc_asprintf(root_ctx, argv[0]);

    `-Werror=format-security`: should be `...(root_ctx, "%s", argv[0]);`. […]

    yes, seems i wasn't paying attention, thx

To view, visit change 32561. To unsubscribe, or for help writing mail filters, visit settings.