Attention is currently required from: laforge, fixeria.
View Change
1 comment:
Patchset:
Patch Set #3:
I don't really like it much, but I have no other/better proposal. […]
I tried that first, see first versions of this patch. But that poses problems since the primitive types prepended at the start are not packed, so it ends up full of unaligned pointers.
In general having all the struct osmo_prim stuff not packed it something which really affects a lot of code, and we'll have to fix lots of stuff in the future or simply live with it and do this sort of tricks.
To view, visit change 29260. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I632654221826340423e1e97b0f8ed9a2baf6c6c3
Gerrit-Change-Number: 29260
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Comment-Date: Thu, 08 Sep 2022 13:06:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge@osmocom.org>
Gerrit-MessageType: comment