Attention is currently required from: osmith, laforge.
10 comments:
File include/osmocom/core/tun.h:
Patch Set #9, Line 29: const char *osmo_tundev_get_name(const struct osmo_tundev *tundev);
maybe add a new line below this? given that the two functions below are about dev_name, and there's […]
Ack
File src/core/tun.c:
Patch Set #4, Line 421: osmo_tundev_encaps
agreed
Ack
File src/core/tun.c:
Add "Prepare netns: " for consistency with other messages in this function?
Ack
use a global talloc ctx and pass that here?
I don't plan to pass this from the API, since the ctx passed there is per tundev and may be expected to be freed when the parent object in the app holding the tudnev is released.
We could add an internal static talloc ctx here if needed, but I don't see urgent need for it?
Patch Set #9, Line 233: inreface
interface
Ack
Patch Set #9, Line 284: tundev_mnl_link_state_change
Maybe call it "tundev_mnl_link_on_state_change" (adding _on_)? […]
Ack
is this intentionally the same as in the if (up) case? if so, why have it in both the if and else br […]
Yes this is expected, as per https://git.netfilter.org/libmnl/tree/examples/rtnl/rtnl-link-set.c
Patch Set #9, Line 375: /* RTM_NEWLINK doesn't work either */
leftover comment?
Ack
Patch Set #9, Line 448: status
why status and not len?
Ack
open
Ack
To view, visit change 31025. To unsubscribe, or for help writing mail filters, visit settings.